Skip to content

Mention the blog post in CONTRIBUTING.md #2031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

Mention the blog post in CONTRIBUTING.md #2031

merged 2 commits into from
Jun 23, 2025

Conversation

martinbonnin
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jun 20, 2025

@martinbonnin is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@martinbonnin martinbonnin mentioned this pull request Jun 20, 2025
Open
benjie
benjie approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@benjie benjie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please run yarn format pnpm format and commit the result :)

@martinbonnin
Copy link
Contributor Author

@benjie I tried that but my local setup wasn't super happy about it:

[error] src/icons/linkedin-filled.svg: Error: Cannot find module '@tailwindcss/container-queries'
[error] Require stack:
[error] - /Users/martinbonnin/git/graphql.github.io/tailwind.config.ts
[error]     at Function._resolveFilename (node:internal/modules/cjs/loader:1394:15)
[error]     at Function.resolve (node:internal/modules/helpers:145:19)
[error]     at _resolve (/Users/martinbonnin/git/graphql.github.io/node_modules/.pnpm/jiti@1.21.7/node_modules/jiti/dist/jiti.js:1:246378)
[error]     at jiti (/Users/martinbonnin/git/graphql.github.io/node_modules/.pnpm/jiti@1.21.7/node_modules/jiti/dist/jiti.js:1:249092)
[error]     at /Users/martinbonnin/git/graphql.github.io/tailwind.config.ts:5:25
[error]     at evalModule (/Users/martinbonnin/git/graphql.github.io/node_modules/.pnpm/jiti@1.21.7/node_modules/jiti/dist/jiti.js:1:251913)
[error]     at jiti (/Users/martinbonnin/git/graphql.github.io/node_modules/.pnpm/jiti@1.21.7/node_modules/jiti/dist/jiti.js:1:249841)
[error]     at /Users/martinbonnin/git/graphql.github.io/node_modules/.pnpm/tailwindcss@3.4.17/node_modules/tailwindcss/lib/lib/load-config.js:52:26
[error]     at loadConfig (/Users/martinbonnin/git/graphql.github.io/node_modules/.pnpm/tailwindcss@3.4.17/node_modules/tailwindcss/lib/lib/load-config.js:62:6)
[error]     at Zne (file:///Users/martinbonnin/git/graphql.github.io/node_modules/.pnpm/prettier-plugin-tailwindcss@0.6.9_prettier@3.4.2/node_modules/prettier-plugin-tailwindcss/dist/index.mjs:2487:17944)
All matched files use Prettier code style!
 ELIFECYCLE  Command failed with exit code 2.
 ELIFECYCLE  Command failed with exit code 2.

Does that ring a bell?

@benjie
Copy link
Member

benjie commented Jun 23, 2025 •
edited
Loading

Sorry my bad, you should run pnpm i && pnpm format - I forgot this repo uses pnpm instead of yarn.

Edit: oh, you did.

@benjie
Copy link
Member

benjie commented Jun 23, 2025

No idea; running pnpm i && pnpm format on source works for me 🤷‍♂️

@vercel Vercel
Copy link

vercel bot commented Jun 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graphql-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2025 6:21pm

@benjie benjie merged commit ec6c9f3 into graphql:source Jun 23, 2025
3 of 4 checks passed
@martinbonnin
Copy link
Contributor Author

I think I forgot the pnpm i part 😅 I did just npm i 🤦 Sorry npm noob here! Thanks for fixing it ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjie benjie benjie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinbonnin @benjie